Re: [PATCH RFC] x86/mce: Move MCE sysfs attributes out of the per-cpulocation

[Naveen N. Rao]

On 08/29/2012 03:43 PM, Borislav Petkov wrote:
> On Wed, Aug 29, 2012 at 01:11:55PM +0530, Naveen N. Rao wrote:
> > All the MCE attributes currently exported via sysfs appear under
> > /sys/devices/system/machinecheck/machinecheck<n>/. Pretty much all of these
> > are global in nature and not specific to a processor. We have around 7
> > attributes duplicated across each processor and on multi-core multi-socket
> > machines, this amounts to quite a large number. So, move these out under
> > /sys/devices/system/machinecheck/ where they rightly belong.
> >
> > Note: I'm not sure if it's ok to change sysfs entries and this does break
> > userspace tools that depend on the current path for some of these attributes.
> > So, they will need to be updated to use the new path. However, if we ever get
> > to a point where cpu0 can be offlined, these tools will need to be updated
> > anyway (as they mostly hardcode machinecheck0 currently)
>
> How do you know that for all tools out there?

I don't - I've seen mcelog and related tools and they look in machinecheck0.

> I know, I know, moving them to /sys/.../machinecheck/ is the right thing
> to do but they're exposed to userspace and we're breaking it with this
> patch. And we don't break userspace so I'd guess we're stuck with the
> current situation.

Hmmm.. Can't we just deprecate these? ;)
Perhaps we can consider adding newer tunables in the right place.


Thanks,
Naveen

> Sorry.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/