Re: [PATCH] block: Fix bad range check in bio_sector_offset

From: Jeff Moyer
Date: Wed Aug 29 2012 - 13:49:11 EST


"Martin K. Petersen" <martin.petersen@xxxxxxxxxx> writes:

>>>>>> "Jeff" == Jeff Moyer <jmoyer@xxxxxxxxxx> writes:
>
>>> DM would occasionally end up splitting data integrity-enabled
>>> requests incorrectly. The culprit was a bad range check in
>>> bio_sector_offset.
>
> Jeff> The patch looks ok to me, but what is the user visible behavior
> Jeff> when this happens?
>
> We'd occasionally end up mapping a bad integrity scatterlist and the HBA
> would abort the I/O with a protection information error.

Thanks for the explanation, Martin!

Acked-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/