Re: [PATCH 0/8] lp8727_charger: cleanup code

From: Anton Vorontsov
Date: Thu Aug 30 2012 - 08:17:39 EST


On Thu, Aug 30, 2012 at 11:37:16AM +0000, Kim, Milo wrote:
> LP8727 driver should be patched for several reasons.
>
> (a) Need to clean up _probe()/_remove()
> (b) Not secure code when the platform data is NULL
> (c) Interrupt handling
> Two threads are running for handling one IRQ.
> One is for the IRQ pin, the other is used for delayed processing.
> This is unusual and can be enhanced.
> (d) Misuse of mutex code
> (e) Lots of definitions should be fixed
> (f) Others..

Thanks a lot for the cleanups, this is much appreciated! The cleanups
themselves look great, but I'd really like to see them more separated.

Thanks,
Anton.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/