RE: [PATCH 0/8] lp8727_charger: cleanup code

[Kim, Milo]

> -----Original Message-----
> From: Anton Vorontsov [mailto:anton.vorontsov@xxxxxxxxxx]
> Sent: Thursday, August 30, 2012 9:15 PM
> To: Kim, Milo
> Cc: linux-kernel@xxxxxxxxxxxxxxx; David Woodhouse
> Subject: Re: [PATCH 0/8] lp8727_charger: cleanup code
> 
> On Thu, Aug 30, 2012 at 11:37:16AM +0000, Kim, Milo wrote:
> > LP8727 driver should be patched for several reasons.
> >
> > (a) Need to clean up _probe()/_remove()
> > (b) Not secure code when the platform data is NULL
> > (c) Interrupt handling
> >     Two threads are running for handling one IRQ.
> >     One is for the IRQ pin, the other is used for delayed processing.
> >     This is unusual and can be enhanced.
> > (d) Misuse of mutex code
> > (e) Lots of definitions should be fixed
> > (f) Others..
> 
> Thanks a lot for the cleanups, this is much appreciated! The cleanups
> themselves look great, but I'd really like to see them more separated.
> 
> Thanks,
> Anton.

Sorry to bother you.
I'll resend the patch-set separately.
Thanks a lot for detailed review.

Best Regards,
Milo
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶ŸÿÃ-»+ƒùdš_