Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API

From: Matt Porter
Date: Sat Sep 01 2012 - 09:14:53 EST


On Sat, Sep 01, 2012 at 06:32:29AM +0530, Vinod Koul wrote:
> On Fri, 2012-08-31 at 22:32 +0530, Vinod Koul wrote:
> > On Fri, 2012-08-31 at 22:01 +0530, Sekhar Nori wrote:
> > > >> Yes, this was the problem. Since the SPI driver now depends on
> > > >> CONFIG_TI_EDMA for basic operation may be select CONFIG_TI_EDMA in
> > > >> Kconfig if SPI is enabled? That should do until the fallback to PIO
> > > is
> > > >> implemented.
> > > > Then this should be enabled for SPI. Care to send a patch
> > >
> > > By 'this' you mean the Kconfig select? Then there should be no need of
> > > a
> > > new patch for this. It can be part of this patch itself, no?
> > Either way is okay for me.
> And am in good mood :)

I am as well...thanks for taking care of the patch to address the Kconfig
issue and applying. It's nice to return from holiday and not have to do
anything with this series. :)

-Matt

> Applied all with this as well
>
> >From b5f14330590118e6a0659255476c0f24ab681e05 Mon Sep 17 00:00:00 2001
> From: Vinod Koul <vinod.koul@xxxxxxxxxxxxxxx>
> Date: Sat, 1 Sep 2012 06:29:22 +0530
> Subject: [PATCH] spi: davici - make davinci select edma
>
> Reported-by: Sekhar Nori <nsekhar@xxxxxx>
> Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxxxxxxxx>
> ---
> drivers/spi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 5f84b55..b9fb9a1 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -134,6 +134,7 @@ config SPI_DAVINCI
> tristate "Texas Instruments DaVinci/DA8x/OMAP-L/AM1x SoC SPI
> controller"
> depends on ARCH_DAVINCI
> select SPI_BITBANG
> + select TI_EDMA
> help
> SPI master controller for DaVinci/DA8x/OMAP-L/AM1x SPI modules.
>
> --
> 1.7.9.5
>
>
>
> --
> ~Vinod Koul
> Intel Corp.
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/