Re: [PATCH v4 3/3] avr32: at32ap700x: set DMA slave properties forMCI dw_dmac

[Andy Shevchenko]

On Sun, Sep 2, 2012 at 8:54 PM, Hein Tibosch <hein_tibosch@xxxxxxxx> wrote:
> --- a/arch/avr32/mach-at32ap/at32ap700x.c
> +++ b/arch/avr32/mach-at32ap/at32ap700x.c
> @@ -1355,6 +1355,10 @@ at32_add_device_mci(unsigned int id, struct mci_platform_data *data)
>                                 | DWC_CFGH_DST_PER(1));
>         slave->sdata.cfg_lo &= ~(DWC_CFGL_HS_DST_POL
>                                 | DWC_CFGL_HS_SRC_POL);
> +       /* Setup DMA controller: let source be master */
> +       slave->sdata.src_master = 1;
I don't know the details, but do you want to set up dst_master as well?

> +       /* Limit maximum transfer width to 32-bit */
> +       slave->sdata.max_mem_width = DW_MEM_WIDTH_32;
It's under question regarding to my comments on previous patch.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/