Re: [PATCH 1/4] i2c: introduce i2c-cbus driver

[Felipe Balbi]

Hi,

On Tue, Sep 04, 2012 at 12:31:42PM +0300, Aaro Koskinen wrote:
> On Tue, Sep 04, 2012 at 12:05:07PM +0300, Felipe Balbi wrote:
> > > + * CBUS I2C driver for Nokia Internet Tablets.
> 
> [...]
> 
> > this version misses the entire IRQ handling we already had on linux-omap
> > tree, so it's quite a regression.
> 
> There's no interrupts used in plain CBUS protocol/communication I think?
> 
> But Retu MFD supports the GPIO IRQ. I added the code for this set. And
> the power button driver (patch 4/4) is using this functionality:
> 
> # cat /proc/interrupts
> [...]
> 204:         29      GPIO  retu-mfd
> 224:         29      RETU  retu-pwrbutton

oops, indeed. My bad. I looked at the wrong patch. Nevermind, this
series looks good to me.

FWIW:

Acked-by: Felipe Balbi <balbi@xxxxxx>

(for entire series)

-- 
balbi

Attachment: signature.asc
Description: Digital signature