Re: [PATCH 05/11] asus-wmi: Restrict debugfs interface

From: Alan Cox
Date: Tue Sep 04 2012 - 12:07:12 EST


On Tue, 4 Sep 2012 11:55:11 -0400
Matthew Garrett <mjg@xxxxxxxxxx> wrote:

> We have no way of validating what all of the Asus WMI methods do on a
> given machine, and there's a risk that some will allow hardware state to
> be manipulated in such a way that arbitrary code can be executed in the
> kernel. Add a capability check to prevent that.

This is true of any firmware method on any device Why pick on ASUS. Have
you run this through ASUS and discussed it with them. It seems highly
inappropriate to cripple a specific vendors feature set without
discussion and an Ack from the vendor concerned.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/