Re: [PATCH 08/10] net/macb: macb_get_drvinfo: add GEM/MACB suffixto differentiate revision

From: David Miller
Date: Wed Sep 05 2012 - 17:31:13 EST


From: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
Date: Wed, 5 Sep 2012 11:00:53 +0200

> strcpy(info->driver, bp->pdev->dev.driver->name);
> + if (macb_is_gem(bp))
> + strcat(info->driver, " GEM");
> + else
> + strcat(info->driver, " MACB");

This is a driver string, which means the software driver, and has
absolutely nothing to do with the exact type of the underlying
physical hardware.

Therefore the these suffixes should be left out of the driver string.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/