Re: [PATCH] Don't clobber access methods when !regmap

From: Pantelis Antoniou
Date: Thu Sep 06 2012 - 10:02:44 EST


Hi,

On Sep 6, 2012, at 5:01 PM, Peter Ujfalusi wrote:

> Hi,
>
> On 09/05/2012 07:43 PM, Pantelis Antoniou wrote:
>> The driver in question (twl4030.c) does not call snd_soc_codec_set_cache_io().
>> However the snd-soc core does call it in sound/soc/soc-core.c in soc_probe_codec.
>>
>> I do see that there's a commit 98d3088e534a2a61f6690b5426909b0c3b57a785 that is
>> fixing it in a different manner.
>
> I also noticed this (with 3.6-rc1 I think).
> The commit you mention does fix it so we do not have issue anymore.
> I sent two patches related to this:
> http://mailman.alsa-project.org/pipermail/alsa-devel/2012-August/053864.html
> http://mailman.alsa-project.org/pipermail/alsa-devel/2012-August/053876.html
>
> Mark took a different route which gives us the commit you mentioned:
> http://mailman.alsa-project.org/pipermail/alsa-devel/2012-August/053889.html
>
> Regards,
> Péter

Quite similar to my patches. They're not needed now, since I have verified that
the issue is fixed.

Regards

-- Pantelis

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/