Re: [PATCH v2 1/2] [powerpc] Change memory_limit from phys_addr_tto unsigned long long

[Suzuki K. Poulose]

On 09/07/2012 07:05 AM, Benjamin Herrenschmidt wrote:
> On Tue, 2012-08-21 at 17:12 +0530, Suzuki K. Poulose wrote:
> > There are some device-tree nodes, whose values are of type phys_addr_t.
> > The phys_addr_t is variable sized based on the CONFIG_PHSY_T_64BIT.
> >
> > Change these to a fixed unsigned long long for consistency.
> >
> > This patch does the change only for memory_limit.
> >
> > The following is a list of such variables which need the change:
> >
> >   1) kernel_end, crashk_size - in arch/powerpc/kernel/machine_kexec.c
> >
> >   2) (struct resource *)crashk_res.start - We could export a local static
> >      variable from machine_kexec.c.
> >
> > Changing the above values might break the kexec-tools. So, I will
> > fix kexec-tools first to handle the different sized values and then change
> >   the above.
> >
> > Suggested-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Suzuki K. Poulose <suzuki@xxxxxxxxxx>
> > ---
>
> Breaks the build on some configs (with 32-bit phys_addr_t):

Sorry for that.
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/prom.c: In function
> 'early_init_devtree':
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/prom.c:664:25: error:
> comparison of distinct pointer types lacks a cast
>
> I'm fixing that myself this time but please be more careful.
Sure. Thanks Ben for fixing that.

Suzuki

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/