Re: [PATCH 1/3] tools lib traceevent: Get rid of die() frompretty_print()

From: Steven Rostedt
Date: Fri Sep 07 2012 - 10:38:13 EST


On Fri, 2012-09-07 at 11:49 +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>
> There are three cases that call die() in the pretty_print.
>
> 1. insufficient number of argument: cannot proceed anymore.
> 2. too long format conversion specifier: truncate and proceed.
> 3. bad size specifier in format string: skip and proceed.
>
> For all cases, convert die to do_warning, mark the event as
> EVENT_FL_FAILED and print error message at the last.
>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks Namyung!

Arnaldo,

Please add my "Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>" to all
three of these patches.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/