Re: [PATCH 07/12] perf diff: Add ratio computation way to comparehist entries

From: Namhyung Kim
Date: Fri Sep 07 2012 - 11:41:25 EST


2012-09-07 (ê), 08:33 -0700, Arnaldo Carvalho de Melo:
> Em Fri, Sep 07, 2012 at 02:45:28PM +0900, Namhyung Kim escreveu:
> > On Thu, 6 Sep 2012 17:47:01 +0200, Jiri Olsa wrote:
> > > @@ -263,6 +296,8 @@ static const struct option options[] = {
> > > + OPT_STRING('c', "compute", &compute_str, "delta,ratio (default delta)",
> > > + "Entries differential computation selection"),
> >
> > Why not make it OPT_CALLBACK?
>
> Namhyung, please trim the message to contain just the snippet that is
> related to your comment,

Will do that later. Sorry for the inconvenience!

Thanks,
Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/