RE: regulator: fan53555: vsel_max does not match with the maxvoltage?

From: Yunfan Zhang
Date: Sun Sep 09 2012 - 23:20:12 EST


> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@xxxxxxxxx]
> Sent: 2012å9æ10æ 11:05
> To: Yunfan Zhang
> Cc: Liam Girdwood; Mark Brown; linux-kernel@xxxxxxxxxxxxxxx
> Subject: regulator: fan53555: vsel_max does not match with the max voltage?
>
> Hi Yunfan,
> Just found below issue while reading the code:
>
> For FAN53555_CHIP_ID_04,
> di->vsel_min = 603000;
> di->vsel_max = 1411000;
> di->vsel_step = 12826;
> volt[63] = 1411038
>
> Then volt[63] is greater than the vsel_max now.
> This looks does not make sense.

Axel, Thanks for your findings!
Yes, the volt[63] is GT the vsel_max. Actually vsel_max is not used... The max voltage will be bounded by desc->n_voltages. I will make a patch to remove it to avoid confusing. Thanks a lot!
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ 0¶ìh®å’i