Re: [PATCH 04/16] ARM: imx: move platform_data definitions

[Guennadi Liakhovetski]

On Tue, 11 Sep 2012, Arnd Bergmann wrote:

> On Tuesday 11 September 2012, Guennadi Liakhovetski wrote:
> > Hi Arnd
> > 
> > It probably wouldn't be very difficult to also include 
> > arch/arm/plat-mxc/include/mach/ipu.h in this your patch, but you can also 
> > leave it for later. Just to make sure it's not something that would make 
> > your future patching more complicated.
> > 
> 
> For now, I've done only the straight renames but left the ones that looked
> like they need more complex changes of any sort. Looking at ipu.h, it seems
> that this header file defines data that is used inside of the driver but not
> in the platform device definition, so we'd need to split it up and move
> the part that is only used inside of the driver into a different place.
> 
> Of course, I could alo be mistaken and not have realized that actually all
> of this file is platform data.

ipu.h is used by the dmaengine and IRQ driver under drivers/dma/ipu/, and 
by its users drivers/media/platform/soc_camera/mx3_camera.c and 
drivers/video/mx3fb.c. It has been placed under arch/arm/... because it's 
arch-specific, but in principle I don't see any reason why it cannot 
happily live anywhere under include/...

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/