Re: [PATCH -next] thermal: cpu_cooling.c needs to select CPU_FREQ_TABLE

[Sedat Dilek]

On Thu, Sep 13, 2012 at 10:46 AM, Amit Kachhap <amit.kachhap@xxxxxxxxxx> wrote:
> On 13 September 2012 03:06, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>>
>> cpu_cooling.c (CONFIG_CPU_THERMAL) uses cpu frequency table
>> intefaces so it should select CPU_FREQ_TABLE.
>> Fixes these build errors:
>>
>> drivers/built-in.o: In function `cpufreq_get_max_state':
>> cpu_cooling.c:(.text+0x4e1297): undefined reference to `cpufreq_frequency_get_table'
>> drivers/built-in.o: In function `cpufreq_set_cur_state':
>> cpu_cooling.c:(.text+0x4e138b): undefined reference to `cpufreq_frequency_get_table'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>> Cc: Amit Daniel <amit.kachhap@xxxxxxxxxx>

Feel free to add:

      Tested-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>

>> ---
>>  drivers/thermal/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> Also, please add info in the MAINTAINERS file for drivers/thermal/.
>>
>> --- linux-next-20120912.orig/drivers/thermal/Kconfig
>> +++ linux-next-20120912/drivers/thermal/Kconfig
>> @@ -22,6 +22,7 @@ config THERMAL_HWMON
>>  config CPU_THERMAL
>>         bool "generic cpu cooling support"
>>         depends on THERMAL && CPU_FREQ
>> +       select CPU_FREQ_TABLE
>
> This change looks good to me. Even similar select is present platform
> cpufreq drivers which uses the cpufreq API's.
>
> Thanks,
> Amit Daniel
>>         help
>>           This implements the generic cpu cooling mechanism through frequency
>>           reduction, cpu hotplug and any other ways of reducing temperature. An
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/