Re: [PATCH 06/19] ARM: ux500: Add nodes for the MSP into the HREFDevice Tree

[Lee Jones]

On Mon, Sep 10, 2012 at 02:53:45AM -0700, Linus Walleij wrote:
> On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> 
> > This patch enables the two important MSP devices for ST-Ericsson's
> > hardware reference development board.
> >
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/hrefv60plus.dts |    8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts
> > index 62b2ac1..4f0aee8 100644
> > --- a/arch/arm/boot/dts/hrefv60plus.dts
> > +++ b/arch/arm/boot/dts/hrefv60plus.dts
> > @@ -77,5 +77,13 @@
> >
> >                         status = "okay";
> >                 };
> > +
> > +               msp1: msp@80124000 {
> > +                       status = "okay";
> > +               };
> > +
> > +               msp3: msp@80125000 {
> > +                       status = "okay";
> > +               };
> >         };
> >  };
> 
> Does this really "enable" the MSPs as the title claims?

Yes they do.

> Aren's there any kind of bindings needed, not even a
> register base?

All that information is in the "disabled" node contained in .dtsi file.

+               msp0: msp@80123000 {
+                       compatible = "stericsson,ux500-msp-i2s";
+                       reg = <0x80123000 0x1000>;
+                       interrupts = <0 31 0x4>;
+                       v-ape-supply = <&db8500_vape_reg>;
+                       status = "disabled";

Then this patch "enable"s it (as the title suggests). :)

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/