Re: [PATCH] Fix queueing work if !bdi_cap_writeback_dirty()

From: OGAWA Hirofumi
Date: Mon Sep 17 2012 - 12:55:30 EST


Jan Kara <jack@xxxxxxx> writes:

>> Duplicate flusher - many FSes has own task to flush. Odd behavior in
>> the case of partition - agree, but I'm not sure why metadata is ok, and
>> it is not odd behavior.
> Well, because there is much more of data pages then there is metadata. So
> when you do strange things (like refuse to write / reclaim) with metadata,
> it usually ends up in the noise. But when you start doing similar things
> with data pages, people will notice.

Could you explain more. So, you are thinking we have to fix current
behavior for metadata intensive applications? And what will people
notice?

>> Sorry, I'm not sure your point in latest comment. You are just saying FS
>> must flush pages on writepages()?
> Yes.
>
>> And if alternative plan is acceptable, maybe I will not have interest to
>> this anymore.
> Yes, the alternative plan looks better to me. But all in all I don't want
> to stop you from your experiments :) I mostly just wanted to point out that
> disabling flusher thread for a filesystem has a complex consequences which
> IMHO bring more bad than good.

OK, thanks.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/