Re: [PATCH] dmaengine: add dmanegine slave map api's

From: Linus Walleij
Date: Tue Sep 18 2012 - 17:04:08 EST


On Tue, Sep 18, 2012 at 10:52 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:

> There's a clue in that paragraph about how the DMA engine TX descriptors
> _should_ be handled. "hold a reference" is the clue. Or another way to
> say it, a kref should be embedded in the structure, providing us with
> proper reference counting - and descriptors should only be 'freed'
> (whether that means actually freeing them or placing them into a free
> list) when the last reference is dropped. That's _much_ better to
> understand than this DMA_CTRL_ACK business...

This indeed sounds like a more robust approach by far.
Why didn't we do that from the beginning ...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/