Re: [PATCH] tools lib traceevent: Handle alloc_arg failure

[Namhyung Kim]

Hi Ingo,

2012-09-19 (ì), 13:42 +0200, Ingo Molnar:
> * Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> 
> > +		if (!left) {
> > +			do_warning("%s(%d): not enough memory!", __func__, __LINE__);
> > +			goto out_free;
> 
> > +		if (!right) {
> > +			do_warning("%s(%d): not enough memory!", __func__, __LINE__);
> > +			goto out_free;
> > +		}
> 
> > +		if (!left) {
> > +			do_warning("%s(%d): not enough memory!", __func__, __LINE__);
> > +			goto out_free;
> > +		}
> 
> > +		if (!left) {
> > +			do_warning("%s(%d): not enough memory!", __func__, __LINE__);
> > +			goto out_free;
> > +		}
> 
> > +		if (!right) {
> > +			do_warning("%s(%d): not enough memory!", __func__, __LINE__);
> > +			goto out_free;
> > +		}
> 
> > +		if (!left) {
> > +			do_warning("%s(%d): not enough memory!", __func__, __LINE__);
> > +			goto out_free;
> > +		}
> 
> These repetitive patterns are seriously uglifying the code and 
> are crying out loud for a out_war_free label:
> 
> 		if (!left)
> 			goto out_warn_free;

Yeah, I agree.  But I wanted to add a bit more helpful (to developers)
info - function name and line number - rather than just "not enough
memory" message.  Maybe we could change do_warning to emit such info
automatically.

Thanks,
Namhyung



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/