Re: [PATCH v2 03/26] block: Refactor blk_update_request()

[Tejun Heo]

Hello,

On Mon, Sep 10, 2012 at 05:22:14PM -0700, Kent Overstreet wrote:
>  static void req_bio_endio(struct request *rq, struct bio *bio,
>  			  unsigned int nbytes, int error)
>  {
> +	/*
> +	 * XXX: bio_endio() does this. only need this because of the weird
> +	 * flush seq thing.
> +	 */
>  	if (error)
>  		clear_bit(BIO_UPTODATE, &bio->bi_flags);
>  	else if (!test_bit(BIO_UPTODATE, &bio->bi_flags))
>  		error = -EIO;

Isn't this also necessary to record errors on partial completions?

Other than that, I definitely like this.  It would be nice to note
that the custom partial bio advancing in blk_update_request() is
replaced with multiple calls to req_bio_endio().  I don't think it has
any meaningful performance implications.  It's just nice to future
readers of the commit.

Also, it would be really nice if you can verify this actually works
with partial blk_update_request().  sector update bug in the previous
patch scares me a bit.  Implementing some debug hacks in the
completion path might be the easiest way to verify.  A subtle bug here
could be pretty painful.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/