RE: [PATCH v2] USB: PHY: Re-organize Tegra USB PHY driver

[Venu Byravarasu]

> -----Original Message-----
> From: Felipe Balbi [mailto:balbi@xxxxxx]
> Sent: Friday, September 21, 2012 3:07 PM
> To: Venu Byravarasu
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; balbi@xxxxxx; Stephen Warren; linux-
> kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-
> tegra@xxxxxxxxxxxxxxx; Stephen Warren; stern@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2] USB: PHY: Re-organize Tegra USB PHY driver
> 
> * PGP Signed by an unknown key
> 
> Hi,
> 
> On Thu, Sep 20, 2012 at 05:32:36PM +0530, Venu Byravarasu wrote:
> > Thanks Greg, for quick response.
> 
> I'm waiting for a newer version fixing Kishon's comments. 

As I mentioned in reply to his comments,  most of the patch is
dealing with re-organizing the code. Hence kept the cleaning
part aside for next patch.

> BTW, his comment about pdata usage is 100% valid. You should fix that.
> 

Are you referring to below comments:

It's better you have the below code under *if (np)*, since both device
node and pdata co-exist for you.
> +       phy_type = of_property_match_string(np, "phy_type", "utmi");
> +       if (phy_type >= 0)
 
If so, I can address it and push an updated patch with that.

> --
> balbi
> 
> * Unknown Key
> * 0x35CAA444
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/