Re: [PATCH v2 0/3] input: Dynamic Minor Numbers

[David Herrmann]

Hi Dmitry

On Fri, Sep 21, 2012 at 11:22 AM, David Herrmann
<dh.herrmann@xxxxxxxxxxxxxx> wrote:
> Hi Dmitry
>
> On Fri, Sep 21, 2012 at 10:07 AM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
>> Thank you very much for working on this, unfortunately your patch extends the
>> existing infrastructure handling of character devices in input core,
>> which is quite rigid and sub-optimal.
>>
>> For a while now I wanted to stop input core from pre-creating character
>> devices and multiplexing file operations and instead push more chardev
>> handling tasks into individual input handlers and make they more
>> independent from input core. So while I won't be taking your patch as is
>> it was a great motivator to finally do something about current
>> limitation and I would appreciate if you could take a look at the patch
>> below and see if you have any issues with it.
>
> I didn't know why we did that, anyway. But I tried to keep that logic,
> even though it is really weird. So I am quite glad that you fixed it.

Sorry, compiling a kernel takes 44m here so I haven't had time earlier
this day. But I just recompiled with your patch and it works like a
charm. I have attached output of "ls -la /dev/input" with 900 uinput
devices. Performance does suck but that is definitely another issue.

So here's my:
Tested-by: David Herrmann <dh.herrmann@xxxxxxxxxxxxxx>

I will review the rest tomorrow.
Cheers
David

Attachment: lx_output
Description: Binary data