Re: [PATCH] backlight: platform-lcd: Add support for device treebased probe

[Andrew Morton]

On Fri, 21 Sep 2012 10:27:07 +0900
Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:

> This patch adds the of_match_table to platform-lcd driver to be
> probed when platform-lcd device node is found in the device tree.
> 
> Cc: Richard Purdie <rpurdie@xxxxxxxxx>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
>  drivers/video/backlight/platform_lcd.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c
> index b667234..574d5ee 100644
> --- a/drivers/video/backlight/platform_lcd.c
> +++ b/drivers/video/backlight/platform_lcd.c
> @@ -145,6 +145,14 @@ static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend,
>  			platform_lcd_resume);
>  #endif
>  
> +#ifdef CONFIG_OF
> +static const struct of_device_id platform_lcd_of_match[] = {
> +	{ .compatible = "platform-lcd" },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, platform_lcd_of_match);
> +#endif
> +
>  static struct platform_driver platform_lcd_driver = {
>  	.driver		= {
>  		.name	= "platform-lcd",
> @@ -152,6 +160,7 @@ static struct platform_driver platform_lcd_driver = {
>  #ifdef CONFIG_PM
>  		.pm	= &platform_lcd_pm_ops,
>  #endif
> +		.of_match_table = of_match_ptr(platform_lcd_of_match),
>  	},
>  	.probe		= platform_lcd_probe,
>  	.remove		= __devexit_p(platform_lcd_remove),

This .c file includes no open-firmware headers.

It does happen to get a copy of of.h via fb.h->i2c.h->of.h, but that
was just luck.

I did this:

--- a/drivers/video/backlight/platform_lcd.c~backlight-platform-lcd-add-support-for-device-tree-based-probe-fix
+++ a/drivers/video/backlight/platform_lcd.c
@@ -16,6 +16,7 @@
 #include <linux/fb.h>
 #include <linux/backlight.h>
 #include <linux/lcd.h>
+#include <linux/of.h>
 #include <linux/slab.h>
 
 #include <video/platform_lcd.h>
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/