Re: [RFC] tty: Add get- ioctls to fetch tty status

From: Greg Kroah-Hartman
Date: Sat Sep 22 2012 - 21:10:52 EST


On Sun, Sep 23, 2012 at 01:52:32AM +0400, Cyrill Gorcunov wrote:
> On Sun, Sep 23, 2012 at 12:11:44AM +0400, Cyrill Gorcunov wrote:
> >
> > > Sysfs is one value per file, you have three values here, please make 3
> > > files.
> > >
> > > And document them in Documentation/ABI/.
> >
> > Hmm, sure Greg, I'll update. Thanks!
>
> Something like below I suppose? Look, if there will be no complains
> on tech aspects on the patch (locking and tty refs) -- I'll update
> Documentation. Just want be sure I've made no mistakes here.
>
> Another question -- would not it be worth to wrap code with
> CONFIG_CHECKPOINT_RESTORE?

Alan's point stands, what's the use of this if it can instantly change
after you read the value?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/