Re: [PATCH] Thermal: Fix bug on generic thermal framework.

[jonghwa3 . lee]

On 2012ë 09ì 24ì 17:08, R, Durgadoss wrote:
> Hi,
>
> Patch is fine, but I think you have to re-base on top of
> Rui's -next branch here:
> git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git
>
> Also, adding Rui to this mail, not sure whether he is in LKML/pm.
>
> Thanks,
> Durga

I'll re-base and re-post it.
Thanks

>> -----Original Message-----
>> From: Jonghwa Lee [mailto:jonghwa3.lee@xxxxxxxxxxx]
>> Sent: Monday, September 24, 2012 7:36 AM
>> To: linux-pml@xxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx; Brown, Len; Rafael J. Wysocki; Andrew
>> Morton; Amit Kachhap; R, Durgadoss; Jonghwa Lee
>> Subject: [PATCH] Thermal: Fix bug on generic thermal framework.
>>
>> When system fails to bind cooling devices to thermal zone device during
>> registering thermal zone device, it leaves registering without canceling
>> delayed work. It probably makes panic if polling rate is not enough to release
>> that work from workqueue. So it is better to ignore initialization of polling
>> work to prevent that unexpected state.
>>
>> Signed-off-by: Jonghwa Lee <jonghwa3.lee@xxxxxxxxxxx>
>> ---
>>  drivers/thermal/thermal_sys.c |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
>> index 2ab31e4..744e69d 100644
>> --- a/drivers/thermal/thermal_sys.c
>> +++ b/drivers/thermal/thermal_sys.c
>> @@ -1351,12 +1351,14 @@ struct thermal_zone_device
>> *thermal_zone_device_register(const char *type,
>>  		}
>>  	mutex_unlock(&thermal_list_lock);
>>
>> +	if (result)
>> +		goto unregister;
>> +
>>  	INIT_DELAYED_WORK(&(tz->poll_queue),
>> thermal_zone_device_check);
>>
>>  	thermal_zone_device_update(tz);
>>
>> -	if (!result)
>> -		return tz;
>> +	return tz;
>>
>>  unregister:
>>  	release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id);
>> --
>> 1.7.4.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/