Re: [PATCH 05/14] userns: Convert hostfs to use kuid and kgid whereappropriate

From: Serge Hallyn
Date: Mon Sep 24 2012 - 10:55:41 EST


Quoting Richard Weinberger (richard@xxxxxx):
> Am 21.09.2012 02:28, schrieb Eric W. Biederman:
> > From: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> >
> > Cc: Jeff Dike <jdike@xxxxxxxxxxx>
> > Cc: Richard Weinberger <richard@xxxxxx>
> > Acked-by: Serge Hallyn <serge.hallyn@xxxxxxxxxxxxx>
> > Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> > ---
>
> Looks sane to me.
>
> Acked-by: Richard Weinberger <richard@xxxxxx>
>
> BTW: How you do test your user namespace patches?

I've got a few specific tests of the new functionality in the usernstest.c
in the nsexec package at
https://launchpad.net/~serge-hallyn/+archive/userns-natty/+sourcepub/2530252/+listing-archive-extra .
Of course LTP already has a good set of test cases for the regular
functionality.

> Is there a generic way to compare/verify uids within a namespace vs. the initial namespace?

It's good to look at output of 'id' in the task versus 'ps' from the initial ns,
as well as create a file and look at the stat output from both namespaces.

-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/