RE: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irqaffinity mask

From: Liu, Chuansheng
Date: Wed Sep 26 2012 - 04:10:09 EST


> Btw, on a slightly different note, I'm also rather surprised that the above
> code doesn't care about the return value of chip->irq_set_affinity() ..
> Shouldn't we warn if that fails?

It seems another case when irq_set_affinity is NULL whenever affinity is changed or not before that,
For this case, I suppose the chip is not supporting set_affinity, then the chip should set all
related irqs into just CPU0, otherwise, it will bring some trouble, do you agree?

I guess this case should be covered outside fixup_irqs() code.

èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—