Re: BUG_ON/panic proliferation.

From: Alan Cox
Date: Fri Sep 28 2012 - 06:03:38 EST


> Remove panic calls from drivers/tty/pty.c
>
> There is no need to panic the system if the allocation/registration of
> the pty drivers fails. Instead return an error and fail the module load.
>
> Signed-off-by: Ryan Mallon <rmallon@xxxxxxxxx>

NAK

this is pointless complexity

This is early boot up code. If it fails we ran out of memory before even
the base drivers got running. It's already game over.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/