Re: [PATCH] CMA: decrease cc.nr_migratepages after reclaimingpagelist

[Mel Gorman]

On Wed, Sep 26, 2012 at 03:50:12PM +0900, Minchan Kim wrote:
> The reclaim_clean_pages_from_list reclaims clean pages before
> migration so cc.nr_migratepages should be updated.
> Currently, there is no problem but it can be wrong if we
> try to use the vaule in future.
> 
> Cc: Mel Gorman <mgorman@xxxxxxx>
> Cc: Michal Nazarewicz <mina86@xxxxxxxxxx>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx>

Yeah ok. As you say, it shouldn't actually affect anything currently and
cc.migratepages is expected to go out of date after migration meaning we
need update_nr_listpages. This patch looks ok though.

Acked-by: Mel Gorman <mgorman@xxxxxxx>

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/