[ 258/262] gpio-lpc32xx: Fix value handling of gpio_direction_output()

From: Greg Kroah-Hartman
Date: Fri Sep 28 2012 - 15:08:26 EST


From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>

3.5-stable review patch. If anyone has any objections, please let me know.

------------------

From: Roland Stigge <stigge@xxxxxxxxx>

commit b1268d3737c6316016026245eef276eda6b0a621 upstream.

For GPIOs of gpio-lpc32xx, gpio_direction_output() ignores the value argument
(initial value of output). This patch fixes this by setting the level
accordingly.

Signed-off-by: Roland Stigge <stigge@xxxxxxxxx>
Acked-by: Alexandre Pereira da Silva <aletes.xgr@xxxxxxxxx>
Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
drivers/gpio/gpio-lpc32xx.c | 5 +++++
1 file changed, 5 insertions(+)

--- a/drivers/gpio/gpio-lpc32xx.c
+++ b/drivers/gpio/gpio-lpc32xx.c
@@ -307,6 +307,7 @@ static int lpc32xx_gpio_dir_output_p012(
{
struct lpc32xx_gpio_chip *group = to_lpc32xx_gpio(chip);

+ __set_gpio_level_p012(group, pin, value);
__set_gpio_dir_p012(group, pin, 0);

return 0;
@@ -317,6 +318,7 @@ static int lpc32xx_gpio_dir_output_p3(st
{
struct lpc32xx_gpio_chip *group = to_lpc32xx_gpio(chip);

+ __set_gpio_level_p3(group, pin, value);
__set_gpio_dir_p3(group, pin, 0);

return 0;
@@ -325,6 +327,9 @@ static int lpc32xx_gpio_dir_output_p3(st
static int lpc32xx_gpio_dir_out_always(struct gpio_chip *chip, unsigned pin,
int value)
{
+ struct lpc32xx_gpio_chip *group = to_lpc32xx_gpio(chip);
+
+ __set_gpo_level_p3(group, pin, value);
return 0;
}



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/