Re: [PATCH] net: fix neigh_resolve_output can cause skb_under_panic

[gregkh@xxxxxxxxxxxxxxxxxxx]

On Fri, Sep 28, 2012 at 08:26:51PM -0400, Ramesh Nagappa wrote:
> > 
> > Why is all of this in the middle of the changelog section?
> > 
> > I'm guessing you didn't use 'git send-email' for this?
> > 
> > And why are you copying me on the patch?
> 
> I got the CC list from scripts/get_maintainers.pl
> 
> asglx-2-300 $ scripts/get_maintainer.pl 0001-net-fix-neigh_resolve_output-can-cause-skb_under_pan.patch
> "David S. Miller" <davem@xxxxxxxxxxxxx> (maintainer:NETWORKING [GENERAL],commit_signer:3/4=75%)
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (commit_signer:3/4=75%)
> Eric Dumazet <eric.dumazet@xxxxxxxxx> (commit_signer:2/4=50%)
> Shawn Lu <shawn.lu@xxxxxxxxxxxx> (commit_signer:1/4=25%)
> Michel Machado <michel@xxxxxxxxxxxxxxx> (commit_signer:1/4=25%)
> netdev@xxxxxxxxxxxxxxx (open list:NETWORKING [GENERAL])
> linux-kernel@xxxxxxxxxxxxxxx (open list)

I can't reproduce this:
	$ ./scripts/get_maintainer.pl --file net/core/neighbour.c
	"David S. Miller" <davem@xxxxxxxxxxxxx> (maintainer:NETWORKING [GENERAL],commit_signer:22/22=100%)
	Eric Dumazet <edumazet@xxxxxxxxxx> (commit_signer:4/22=18%)
	"Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> (commit_signer:2/22=9%)
	Pavel Emelyanov <xemul@xxxxxxxxxxxxx> (commit_signer:2/22=9%)
	netdev@xxxxxxxxxxxxxxx (open list:NETWORKING [GENERAL])
	linux-kernel@xxxxxxxxxxxxxxx (open list)

What tree are you doing that against?

> > You need a blank line before the first Signed-off-by: line.  
> > Surely one of the reviewers should have caught this basic thing?
> 
> Outlook mangled the patch. I am unable to use git send-email because of
> a corporate firewall on the build machine.

Then your patch would also be corrupted, Outlook, and Exchange, can not
handle patches at all.  Please read Documentation/email_clients.txt for
more details.

Also, ask your coworkers who properly submit patches what they do to
work around your broken email infrastructure.

good luck,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/