Re: linux-next: Tree for Sept 24 (remoteproc)

[Ohad Ben-Cohen]

On Tue, Sep 25, 2012 at 12:10 AM, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> on x86_64:
>
> drivers/built-in.o: In function `rproc_virtio_finalize_features':
> remoteproc_virtio.c:(.text+0x2f9a02): undefined reference to `vring_transport_features'
> drivers/built-in.o: In function `rproc_virtio_del_vqs':
> remoteproc_virtio.c:(.text+0x2f9a74): undefined reference to `vring_del_virtqueue'
> drivers/built-in.o: In function `rproc_virtio_find_vqs':
> remoteproc_virtio.c:(.text+0x2f9c44): undefined reference to `vring_new_virtqueue'
> drivers/built-in.o: In function `rproc_add_virtio_dev':
> (.text+0x2f9e2c): undefined reference to `register_virtio_device'
> drivers/built-in.o: In function `rproc_vq_interrupt':
> (.text+0x2f9db7): undefined reference to `vring_interrupt'
> drivers/built-in.o: In function `rproc_remove_virtio_dev':
> (.text+0x2f9e9f): undefined reference to `unregister_virtio_device'


Thanks, Randy, I'm applying this:


commit 8676079c6d31605268a7903a09fdf616e2ef5551
Author: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
Date:   Sun Sep 30 10:25:34 2012 +0200

    remoteproc: select VIRTIO to avoid build breakage

    drivers/built-in.o: In function `rproc_virtio_finalize_features':
    remoteproc_virtio.c:(.text+0x2f9a02): undefined reference to `vring_transpor
    drivers/built-in.o: In function `rproc_virtio_del_vqs':
    remoteproc_virtio.c:(.text+0x2f9a74): undefined reference to `vring_del_virt
    drivers/built-in.o: In function `rproc_virtio_find_vqs':
    remoteproc_virtio.c:(.text+0x2f9c44): undefined reference to `vring_new_virt
    drivers/built-in.o: In function `rproc_add_virtio_dev':
    (.text+0x2f9e2c): undefined reference to `register_virtio_device'
    drivers/built-in.o: In function `rproc_vq_interrupt':
    (.text+0x2f9db7): undefined reference to `vring_interrupt'
    drivers/built-in.o: In function `rproc_remove_virtio_dev':
    (.text+0x2f9e9f): undefined reference to `unregister_virtio_device'

    Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
    Signed-off-by: Ohad Ben-Cohen <ohad@xxxxxxxxxx>

diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index a1024d9..96ce101 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -6,6 +6,7 @@ config REMOTEPROC
        depends on EXPERIMENTAL
        depends on HAS_DMA
        select FW_CONFIG
+       select VIRTIO

 config OMAP_REMOTEPROC
        tristate "OMAP remoteproc support"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/