Re: [PATCH] tools lib traceevent: Fix missed freeing of subargs infree_arg() in filter

From: Steven Rostedt
Date: Mon Oct 01 2012 - 09:42:26 EST


On Mon, 2012-10-01 at 22:16 +0900, Namhyung Kim wrote:

> Although they have same layout, wouldn't it be better using their own
> fields?
>
> case FILTER_ARG_NUM:
> free_arg(arg->num.left);
> free_arg(arg->num.right);
> break;
>
> case FILTER_ARG_EXP:
> free_arg(arg->exp.left);
> free_arg(arg->exp.right);
> break;

Yeah, I got lazy. This is probably better. I'll resend.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/