Re: [PATCH v7 03/49] audit: no need to walk list in audit_inode ifname is NULL

From: Christoph Hellwig
Date: Tue Oct 02 2012 - 11:56:38 EST


On Mon, Oct 01, 2012 at 08:16:12PM -0400, Jeff Layton wrote:
> If name is NULL then the condition in the loop will never be true. Also,
> with this change, we can eliminate the check for n->name == NULL since
> the equivalence check will never be true if it is.

Given that name == NULL is a static condition it seems like these
should be two different calls, E.g. audit_dentry and audit_path.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/