Re: [GIT PULL] drbd-8.3 updates

From: Jens Axboe
Date: Wed Oct 03 2012 - 10:04:46 EST


On 2012-10-03 15:49, Philipp Reisner wrote:
>> Thanks, one question before this is pulled in:
>>> Philipp Reisner (6):
>>> drbd: Add a drbd directory to sysfs
>>> drbd: expose the data generation identifiers via sysfs
>>
>> What are these? It's sitting in /sys/block/<dev>/drbd/, I don't see any
>> documentation or justification for that.
>>
>> Why isn't it off in debugfs or similar instead?
>
> The long-time goal is to get rid of the /proc/drbd virtual file, and
> present the information that was there in a more structured way in /sys.
>
> This patch adds a very first step into that direction. Later we intend to
> have here things like the connections state, device roles, statistics
> counters there.
>
> When coming up with the layout we used the sysfs presence of software raid
> as example.

Software raid is different, though, in that it's a class/type of device.
So for drbd, I'd still recommend you look outside of the regular
/sys/block hierarchy for adding something like this.

> I have removed it from this pull-request, so that there is more time for
> consideration before the next merge window.

Thanks, pulled.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/