Re: [PATCH 08/17] ARM: at91: unused variable inat91_pm_verify_clocks

[Jean-Christophe PLAGNIOL-VILLARD]

On 08:28 Thu 04 Oct     , Arnd Bergmann wrote:
> On Tuesday 02 October 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > >  	unsigned long scsr;
> > > +#ifdef CONFIG_AT91_PROGRAMMABLE_CLOCKS
> > >  	int i;
> > > +#endif
> > please is if (IS_ENBLED())
> > 
> > #ifdef drop code coverage
> > 
> 
> Ok, agreed. Here is the new version:
> 
> From bacd47abb36104665261c84f6f85bba7aef8a521 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@xxxxxxxx>
> Date: Mon, 30 Apr 2012 13:00:32 +0000
> Subject: [PATCH] ARM: at91: unused variable in at91_pm_verify_clocks
> 
> The code using the variable 'i' in this function is conditional which
> results in a harmless compiler warning. Using the IS_ENABLED macro
> instead of #ifdef makes the code look nicer and gets rid of the
> warning.
> 
> Without this patch, building at91sam9263_defconfig results in:
> 
> /home/arnd/linux-arm/arch/arm/mach-at91/pm.c: In function 'at91_pm_verify_clocks':
> /home/arnd/linux-arm/arch/arm/mach-at91/pm.c:137:6: warning: unused variable 'i' [-Wunused-variable]
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/