Re: net: fix typo in freescale/ucc_geth.c

From: Eric Dumazet
Date: Tue Oct 09 2012 - 02:04:51 EST


On Tue, 2012-10-09 at 10:52 +1100, Michael Neuling wrote:
> The following patch:
> acb600d net: remove skb recycling
> added dev_free_skb() to drivers/net/ethernet/freescale/ucc_geth.c
>
> This is a typo and should be dev_kfree_skb(). This fixes this.
>
> Signed-off-by: Michael Neuling <mikey@xxxxxxxxxxx>
> ---
> This hit as a compile error in next-20121008 with mpc85xx_defconfig.
>
> diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
> index dfa0aaa..0a70bb5 100644
> --- a/drivers/net/ethernet/freescale/ucc_geth.c
> +++ b/drivers/net/ethernet/freescale/ucc_geth.c
> @@ -3268,7 +3268,7 @@ static int ucc_geth_rx(struct ucc_geth_private *ugeth, u8 rxQ, int rx_work_limit
> if (netif_msg_rx_err(ugeth))
> ugeth_err("%s, %d: ERROR!!! skb - 0x%08x",
> __func__, __LINE__, (u32) skb);
> - dev_free_skb(skb);
> + dev_kfree_skb(skb);
>
> ugeth->rx_skbuff[rxQ][ugeth->skb_currx[rxQ]] = NULL;
>

Oops, thanks Michael !


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/