Re: [PATCH 2/4 v2] irqdomain: augment add_simple() to allocate descs

[Rob Herring]

On 10/10/2012 01:54 AM, Linus Walleij wrote:
> On Mon, Oct 1, 2012 at 2:11 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:
>> On 10/01/2012 02:35 AM, Linus Walleij wrote:
>>> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>>
>>> Currently we rely on all IRQ chip instances to dynamically
>>> allocate their IRQ descriptors unless they use the linear
>>> IRQ domain. So for irqdomain_add_legacy() and
>>> irqdomain_add_simple() the caller need to make sure that
>>> descriptors are allocated.
>>>
>>> Let's slightly augment the yet unused irqdomain_add_simple()
>>> to also allocate descriptors as a means to simplify usage
>>> and avoid code duplication throughout the kernel.
>>>
>>> We warn if descriptors cannot be allocated, e.g. if a
>>> platform has the bad habit of hogging descriptors at boot
>>> time.
>>>
>>> Cc: Rob Herring <rob.herring@xxxxxxxxxxx>
>>> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>>> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
>>> Cc: Paul Mundt <lethal@xxxxxxxxxxxx>
>>> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
>>> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
>>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>
>> Looks good.
>>
>> Reviewed-by: Rob Herring <rob.herring@xxxxxxxxxxx>
> 
> So what do we do with this patch? Grant?
> 
> I think the change is good to get in ASAP and since I
> now have one patch in pinctrl depending on it I have
> tentatively applied it there.
> 
> Nobody sent any irqdomain fixes for this merge
> window, maybe this is the only relevant patch...

I say merge it with what depends on it. There's been plenty of time for
review.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/