Re: [PATCH 03/31] sections: Fix section conflicts in arch/frv

[Geert Uytterhoeven]

On Sat, Aug 18, 2012 at 7:29 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> ---
>  arch/frv/kernel/setup.c         |    2 +-
>  arch/frv/mb93090-mb00/pci-irq.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/frv/kernel/setup.c b/arch/frv/kernel/setup.c
> index 75cf7f4..1f1e5ef 100644
> --- a/arch/frv/kernel/setup.c
> +++ b/arch/frv/kernel/setup.c
> @@ -184,7 +184,7 @@ static struct clock_cmode __pminitdata clock_cmodes_fr555[16] = {
>         [6]     = {     _x1,    _x1_5,  _x1_5,  _x4_5,  _x0_375 },
>  };
>
> -static const struct clock_cmode __pminitdata *clock_cmodes;
> +static const struct clock_cmode __pminitconst *clock_cmodes;

Unfortunately __pminitconst isn't defined at this point:
arch/frv/kernel/setup.c:187:47: error: expected '=', ',', ';', 'asm'
or '__attribute__' before '*' token
arch/frv/kernel/setup.c:386:2: error: 'clock_cmodes' undeclared (first
use in this function)
arch/frv/kernel/setup.c:571:6: error: 'clock_cmodes' undeclared (first
use in this function)
make[2]: *** [arch/frv/kernel/setup.o] Error 1

http://kisskb.ellerman.id.au/kisskb/buildresult/7344691/

It seems the __pminit* variants are frv-specific, and don't cover all possible
combinations?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/