Re: [PATCH] mm: huge_memory: Fix build error.

From: David Rientjes
Date: Mon Oct 15 2012 - 16:51:05 EST


On Mon, 15 Oct 2012, Ralf Baechle wrote:

> Certain configurations won't implicitly pull in <linux/pagemap.h> resulting
> in the following build error:
>
> mm/huge_memory.c: In function 'release_pte_page':
> mm/huge_memory.c:1697:2: error: implicit declaration of function 'unlock_page' [-Werror=implicit-function-declaration]
> mm/huge_memory.c: In function '__collapse_huge_page_isolate':
> mm/huge_memory.c:1757:3: error: implicit declaration of function 'trylock_page' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
>

This is because CONFIG_HUGETLB_PAGE=n so mempolicy.h doesn't include
pagemap.h?

> Reported-by: David Daney <david.daney@xxxxxxxxxx>
> Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/