[RESEND] [PATCH 2/2] random: fix debug format strings

From: Jiri Kosina
Date: Mon Oct 15 2012 - 17:43:29 EST


Fix the following warnings in formatting debug output:

drivers/char/random.c: In function ʽxfer_secondary_poolʼ:
drivers/char/random.c:827: warning: format ʽ%dʼ expects type ʽintʼ, but argument 7 has type ʽsize_tʼ
drivers/char/random.c: In function ʽaccountʼ:
drivers/char/random.c:859: warning: format ʽ%dʼ expects type ʽintʼ, but argument 5 has type ʽsize_tʼ
drivers/char/random.c:881: warning: format ʽ%dʼ expects type ʽintʼ, but argument 5 has type ʽsize_tʼ
drivers/char/random.c: In function ʽrandom_readʼ:
drivers/char/random.c:1141: warning: format ʽ%dʼ expects type ʽintʼ, but argument 5 has type ʽssize_tʼ
drivers/char/random.c:1145: warning: format ʽ%dʼ expects type ʽintʼ, but argument 5 has type ʽssize_tʼ
drivers/char/random.c:1145: warning: format ʽ%dʼ expects type ʽintʼ, but argument 6 has type ʽlong unsigned intʼ

by using '%zd' instead of '%d' to properly denote ssize_t/size_t conversion.

Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
---
drivers/char/random.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/char/random.c b/drivers/char/random.c
index 9ac4443..5d513c3 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -825,7 +825,7 @@ static void xfer_secondary_pool(struct entropy_store *r, size_t nbytes)
bytes = min_t(int, bytes, sizeof(tmp));

DEBUG_ENT("going to reseed %s with %d bits "
- "(%d of %d requested)\n",
+ "(%zd of %d requested)\n",
r->name, bytes * 8, nbytes * 8, r->entropy_count);

bytes = extract_entropy(r->pull, tmp, bytes,
@@ -856,7 +856,7 @@ static size_t account(struct entropy_store *r, size_t nbytes, int min,
spin_lock_irqsave(&r->lock, flags);

BUG_ON(r->entropy_count > r->poolinfo->POOLBITS);
- DEBUG_ENT("trying to extract %d bits from %s\n",
+ DEBUG_ENT("trying to extract %zd bits from %s\n",
nbytes * 8, r->name);

/* Can we pull enough? */
@@ -878,7 +878,7 @@ static size_t account(struct entropy_store *r, size_t nbytes, int min,
}
}

- DEBUG_ENT("debiting %d entropy credits from %s%s\n",
+ DEBUG_ENT("debiting %zd entropy credits from %s%s\n",
nbytes * 8, r->name, r->limit ? "" : " (unlimited)");

spin_unlock_irqrestore(&r->lock, flags);
@@ -1138,11 +1138,11 @@ random_read(struct file *file, char __user *buf, size_t nbytes, loff_t *ppos)
if (n > SEC_XFER_SIZE)
n = SEC_XFER_SIZE;

- DEBUG_ENT("reading %d bits\n", n*8);
+ DEBUG_ENT("reading %zd bits\n", n*8);

n = extract_entropy_user(&blocking_pool, buf, n);

- DEBUG_ENT("read got %d bits (%d still needed)\n",
+ DEBUG_ENT("read got %zd bits (%zd still needed)\n",
n*8, (nbytes-n)*8);

if (n == 0) {
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/