Re: [RFC PATCH 1/5] irq_work: Move irq_work_raise() declaration/default definition to arch headers

From: Arnd Bergmann
Date: Tue Oct 16 2012 - 05:25:28 EST

On Tuesday 16 October 2012, Mark Brown wrote:
> On Tue, Oct 16, 2012 at 12:18:05AM +0200, Frederic Weisbecker wrote:
> I came up with stuff for it, though it needed prettyfying.
> > This seems to do the trick:
> > (It's the diff result of ln -s asm-generic include/asm)

Unfortunately, this is not enough, it breaks "make headers_install",
which now needs to decide whether to install a header that is present
in the architecture directory, or to copy one from the asm-generic
directory otherwise.

On the plus side, the symlink breaks checking into CVS and cross-building
from operating systems that don't support posix file systems, so we
might want to do this anyway. ;-)

> That'd work, but I assume there is some reason why we've got this system
> of explicitly adding each file. It's not like cpp can test for the
> presence of include files. If we can't figure out why we're not doing
> this I'd propose we start.

We discussed renaming asm-generic to asm before, but some people objected
to the use of #include_next. There is a smaller problem with opening the
asm/*.h namespace to header files that are not relevant for architctures,
so I'd prefer to have a well-defined list of headers that are implicitly
shared, but it's not a technical argument.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at