RE: [PATCH v9 12/12] x86, topology: Debug CPU00 hotplug
From: Yu, Fenghua
Date: Tue Oct 16 2012 - 20:06:06 EST
> > +#ifdef CONFIG_DEBUG_HOTPLUG_CPU0
> + case PM_RESTORE_PREPARE:
> > + /*
> > + * When system resumes from hibernation, online CPU0
> > + * 1. it's required for resume and
> > + * 2. the CPU was online before hibernation
> > + */
> > + if (!cpu_online(0))
> > + _debug_hotplug_cpu(0, 1);
> This won't work. CPU hotplug is disabled by cpu_hotplug_pm_callback()
> PM_HIBERNATION_PREPARE and is enabled back only during
> So calls to cpu_up() or cpu_down() will fail in the meantime.
The code works just fine.
You are talking about hibernation/suspend phase. This piece of
code is all about restore phase. Of course you can call cpu_up()
and cpu_down() during restore phase.
So there is no problem here.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/