Re: [ 038/147] block: fix request_queue->flags initialization
From: Ben Hutchings
Date: Tue Oct 16 2012 - 22:11:33 EST
On Tue, 2012-10-16 at 19:59 -0300, Herton Ronaldo Krzesinski wrote:
> On Sun, Oct 14, 2012 at 03:36:11PM +0100, Ben Hutchings wrote:
> > 3.2-stable review patch. If anyone has any objections, please let me know.
> > ------------------
> > From: Tejun Heo <tj@xxxxxxxxxx>
> > commit 60ea8226cbd5c8301f9a39edc574ddabcb8150e0 upstream.
> > A queue newly allocated with blk_alloc_queue_node() has only
> > QUEUE_FLAG_BYPASS set. For request-based drivers,
> > blk_init_allocated_queue() is called and q->queue_flags is overwritten
> > with QUEUE_FLAG_DEFAULT which doesn't include BYPASS even though the
> > initial bypass is still in effect.
> Since QUEUE_FLAG_BYPASS doesn't exist and nothing in
> blk_alloc_queue_node is set on 3.2, this change is uneeded then,
> but the patch should be harmless anyway.
Thanks, I'll drop it.
No political challenge can be met by shopping. - George Monbiot
Description: This is a digitally signed message part