Re: [PATCH] rcu: restore correct batch limiting

From: Eric Dumazet
Date: Wed Oct 17 2012 - 10:01:18 EST


On Wed, 2012-10-17 at 21:18 +0800, Hillf Danton wrote:

> > /* did other CPU force QS recently? */
> > - long blimit; /* Upper limit on a processed batch */
> > + int blimit; /* Upper limit on a processed batch */
> >
> > /* 3) dynticks interface. */
> > + int dynticks_snap; /* Per-GP tracking for dynticks. */
> > struct rcu_dynticks *dynticks; /* Shared per-CPU dynticks state. */
> > - int dynticks_snap; /* Per-GP tracking for dynticks. */
>
> Hm, no words in change log for shuffling dynticks_snap...

I dont like adding two 32bit holes on a structure ;)

This kind of trivial things dont need a changelog, especially when
fixing a critical bug.

I let Paul add this if he really wants.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/