Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.
From: Viresh Kumar
Date: Wed Oct 17 2012 - 13:02:30 EST
On 17 October 2012 22:28, Joe Perches <joe@xxxxxxxxxxx> wrote:
>> > +#include <linux/slab.h>
>> > +#include <linux/module.h>
>> > +#include <linux/platform_device.h>
>> > +#include <linux/cpufreq.h>
>> > +#include <linux/cpu_cooling.h>
>> > +#include <linux/err.h>
>> should be in alphabetical order
> There's no agreed kernel convention here.
> Some prefer christmas tree (shortest to longest length)
I have seen a number of times this happening, because the list
isn't in alphabetical order people aren't able to easily read if an
#include ... is already there or not.
And so one header file is included multiple times. Because git diff
only shows few lines above and below a change, even people can't
catch it in reviews. That's why they must always be in alphabetical order.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/