Re: [PATCH 4/9] ARM: export default read_current_timer

From: Alexander Holler
Date: Thu Oct 18 2012 - 04:44:42 EST

Am 09.10.2012 18:06, schrieb Russell King - ARM Linux:
On Tue, Oct 09, 2012 at 04:40:54PM +0100, Jonathan Austin wrote:
Hi Arnd,

On 09/10/12 16:22, Arnd Bergmann wrote:
diff --git a/arch/arm/lib/delay.c b/arch/arm/lib/delay.c
index 9d0a300..0dc5385 100644
--- a/arch/arm/lib/delay.c
+++ b/arch/arm/lib/delay.c
@@ -45,6 +45,7 @@ int read_current_timer(unsigned long *timer_val)
*timer_val = delay_timer->read_current_timer();
return 0;

Perhaps this fits better in armksyms.c? That way it lives with
arm_delay_ops and friends.

It's always much better to put things next to where they're defined
rather than spreading them around.

armksyms.c is a reminant of the 1.x days of doing things... but still
remains to allow what are mostly assembly symbols to be exported.

I needed that to build udlfb as a module.

For the 3.6 stable kernels this has to be done in
arch/arm/kernel/arch_timer.c (along with an #include <linux/export.h>)

So I'm not sure if an Cc: <stable@xxxxxxxxxxxxxxx> can be used here, but a patch should be submitted for inclusion into the 3.6 stable series too.



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at