Re: [PATCH v2] Documentation DMA-API-HOWTO.txt Add dma mapping errorcheck usage examples

From: Jesper Juhl
Date: Thu Oct 18 2012 - 17:32:49 EST


On Thu, 18 Oct 2012, Shuah Khan wrote:

> Enhance the document to discuss the importance of dma mapping error checks
> after dma_map_single() and dma_map_page() calls. Also added usage examples
> that include unmap examples in error paths when dma mapping error is returned.
> Includes correct and incorrect usages to high light some common mistakes in
> error paths especially when dma mapping fails when more than one dma mapping
> call is made.
>
> Signed-off-by: Shuah Khan <shuah.khan@xxxxxx>
[...]

Nit picking :

> +Example 2: (if buffers are allocated a loop, unmap all mapped buffers when
> + mapping error is detected in the middle)
> +

"... if buffers are allocated in a loop..."

--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/