Re: [PATCH 4/7] gpio/mxs: convert to use linear irqdomain

[Linus Walleij]

On Thu, Oct 18, 2012 at 8:22 AM, Shawn Guo <shawn.guo@xxxxxxxxxx> wrote:

>>       /* gpio-mxs can be a generic irq chip */
>>       mxs_gpio_init_gc(port, irq_base);
>                                ^^^^^^^^
>
> So I know this one is not compile-tested.

No, which defconfig shall I use for this driver?

> This is exactly the reason why I have to use irq_domain_add_legacy
> other than irq_domain_add_linear when I add irqdomain support for the
> driver.  The driver uses generic-irq infrastructural which needs
> irq_base for setup.  So sadly, before generic-irq gets improved, any
> irq chip that uses generic-irq will have to use irq_domain_add_legacy.

Bah, I'm dropping this and a lot of the other patches as well.

I obviously do not understand the inner transcendental meaning of
irqdomains yet.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/